Await cancelation of sending_task in _stream_stream to prevent writing on closed stream.#183
Open
zachary-walravens wants to merge 1 commit intobetterproto:mainfrom
Open
Await cancelation of sending_task in _stream_stream to prevent writing on closed stream.#183zachary-walravens wants to merge 1 commit intobetterproto:mainfrom
zachary-walravens wants to merge 1 commit intobetterproto:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It fixes this issue I created here #182
Essentially, stream_stream doesn't await the cancelation of sending_task when an exception is raised. This allows for an edge case where sending_task tries to send messages on a closed stream, leading to an http error that closes all streams on that channel.
Checklist